Alexander Renz
f9fa1fb817
All checks were successful
CI/CD / Test (push) Successful in 3m4s
CI/CD / Lint (push) Successful in 1m12s
CI/CD / Integration Tests (push) Successful in 51s
CI/CD / Native Engine Tests (push) Successful in 51s
CI/CD / Build Binary (push) Successful in 43s
CI/CD / Test Release Build (push) Successful in 1m20s
CI/CD / Release Binaries (push) Successful in 10m43s
🚨 CRITICAL BUGFIX - Native Engine Panic
This release fixes a critical nil pointer dereference panic that occurred when:
- User pressed Ctrl+C during restore operations in TUI mode
- Context got cancelled while progress callbacks were active
- Race condition between TUI shutdown and goroutine progress updates
Files modified:
- internal/engine/native/recovery.go (NEW) - Panic recovery utilities
- internal/engine/native/postgresql.go - Panic recovery + context checks
- internal/restore/engine.go - Panic recovery for all progress callbacks
- internal/backup/engine.go - Panic recovery for database progress
- internal/tui/restore_exec.go - Safe callback handling
- internal/tui/backup_exec.go - Safe callback handling
- internal/tui/menu.go - Panic recovery for menu
- internal/tui/chain.go - 5s timeout to prevent hangs
Fixes: nil pointer dereference on Ctrl+C during restore
62 lines
2.0 KiB
Bash
Executable File
62 lines
2.0 KiB
Bash
Executable File
#!/bin/bash
|
|
|
|
# Test script to verify the native engine panic fix
|
|
# This script tests context cancellation scenarios that previously caused panics
|
|
|
|
set -e
|
|
|
|
echo "🔧 Testing Native Engine Panic Fix"
|
|
echo "=================================="
|
|
|
|
# Test 1: Quick cancellation test
|
|
echo ""
|
|
echo "Test 1: Quick context cancellation during interactive mode..."
|
|
|
|
# Start interactive mode and quickly cancel it
|
|
timeout 2s ./dbbackup_fixed interactive --auto-select=9 --auto-database=test_panic --auto-confirm || {
|
|
echo "✅ Test 1 PASSED: No panic during quick cancellation"
|
|
}
|
|
|
|
# Test 2: Native restore with immediate cancellation
|
|
echo ""
|
|
echo "Test 2: Native restore with immediate cancellation..."
|
|
|
|
# Create a dummy backup file for testing
|
|
echo "CREATE TABLE test_table (id int);" > test_backup.sql
|
|
|
|
timeout 1s ./dbbackup_fixed restore single test_backup.sql --database=test_panic_restore --native --clean-first || {
|
|
echo "✅ Test 2 PASSED: No panic during restore cancellation"
|
|
}
|
|
|
|
# Test 3: Test with debug options
|
|
echo ""
|
|
echo "Test 3: Testing with debug options enabled..."
|
|
|
|
GOTRACEBACK=all timeout 1s ./dbbackup_fixed interactive --auto-select=9 --auto-database=test_debug --auto-confirm --debug 2>&1 | grep -q "panic\|SIGSEGV" && {
|
|
echo "❌ Test 3 FAILED: Panic still occurs with debug"
|
|
exit 1
|
|
} || {
|
|
echo "✅ Test 3 PASSED: No panic with debug enabled"
|
|
}
|
|
|
|
# Test 4: Multiple rapid cancellations
|
|
echo ""
|
|
echo "Test 4: Multiple rapid cancellations test..."
|
|
|
|
for i in {1..5}; do
|
|
echo " - Attempt $i/5..."
|
|
timeout 0.5s ./dbbackup_fixed interactive --auto-select=9 --auto-database=test_$i --auto-confirm 2>/dev/null || true
|
|
done
|
|
|
|
echo "✅ Test 4 PASSED: No panics during multiple cancellations"
|
|
|
|
# Cleanup
|
|
rm -f test_backup.sql
|
|
|
|
echo ""
|
|
echo "🎉 ALL TESTS PASSED!"
|
|
echo "=================================="
|
|
echo "The native engine panic fix is working correctly."
|
|
echo "Context cancellation no longer causes nil pointer panics."
|
|
echo ""
|
|
echo "🚀 Safe to deploy the fixed version!" |